Skip to content

fix: changing debounce behaviour, adding preventDefault to event on search input#32

Open
GabhenDM wants to merge 1 commit intoglobocom:masterfrom
GabhenDM:fixing-search
Open

fix: changing debounce behaviour, adding preventDefault to event on search input#32
GabhenDM wants to merge 1 commit intoglobocom:masterfrom
GabhenDM:fixing-search

Conversation

@GabhenDM
Copy link
Copy Markdown
Contributor

This PR aims to fix two bugs on the search behaviour.

  1. Search stopped working during the fix of a warning regarding the debounce implementation, using useMemo with an inline func instead of useCallback (both in the end will have the same behaviour, but fixes the weird linting error and doesn't break)
  2. Pressing enter after typing the search query would result in the form post going off, added event.preventDefault() to called function (oops)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant